-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(format): added scopes argument to specify valid scopes #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion and for the PR (with tests!) @mjspeck
I left a couple of comments, please let me know if you have any questions.
Thanks! All the comments make sense. I'll do my best to address them in the coming days. |
@thekaveman I think I addressed all your comments. Let me know if there's anything else you need from me for a re-review. |
so --force-scope and --scopes list next to each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @mjspeck, thank you!
…t to v3.3.0 (#6) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [compilerla/conventional-pre-commit](https://togithub.com/compilerla/conventional-pre-commit) | repository | minor | `v3.2.0` -> `v3.3.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://togithub.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>compilerla/conventional-pre-commit (compilerla/conventional-pre-commit)</summary> ### [`v3.3.0`](https://togithub.com/compilerla/conventional-pre-commit/releases/tag/v3.3.0) [Compare Source](https://togithub.com/compilerla/conventional-pre-commit/compare/v3.2.0...v3.3.0) - added scopes argument to specify valid scopes by [@​mjspeck](https://togithub.com/mjspeck) in [https://github.com/compilerla/conventional-pre-commit/pull/102](https://togithub.com/compilerla/conventional-pre-commit/pull/102) #### What's Changed - chore(pre-commit): autoupdate hooks by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/compilerla/conventional-pre-commit/pull/97](https://togithub.com/compilerla/conventional-pre-commit/pull/97) - chore(pre-commit): autoupdate hooks by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/compilerla/conventional-pre-commit/pull/98](https://togithub.com/compilerla/conventional-pre-commit/pull/98) - chore(pre-commit): autoupdate hooks by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/compilerla/conventional-pre-commit/pull/99](https://togithub.com/compilerla/conventional-pre-commit/pull/99) - chore(pre-commit): autoupdate hooks by [@​pre-commit-ci](https://togithub.com/pre-commit-ci) in [https://github.com/compilerla/conventional-pre-commit/pull/100](https://togithub.com/compilerla/conventional-pre-commit/pull/100) - feat(format): added scopes argument to specify valid scopes by [@​mjspeck](https://togithub.com/mjspeck) in [https://github.com/compilerla/conventional-pre-commit/pull/102](https://togithub.com/compilerla/conventional-pre-commit/pull/102) #### New Contributors - [@​mjspeck](https://togithub.com/mjspeck) made their first contribution in [https://github.com/compilerla/conventional-pre-commit/pull/102](https://togithub.com/compilerla/conventional-pre-commit/pull/102) **Full Changelog**: compilerla/conventional-pre-commit@v3.2.0...v3.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/anza-labs/charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Closes: #101